fix(server): graceful shutdown with open SSE clients + bounded table growth #5

Merged

pregno merged 2 commits from fix/server-lifecycle-retention into main

2026-06-13 01:27:44 +02:00

pregno commented

2026-06-13 01:04:27 +02:00

Owner

Two Important findings from the repo-wide review:

Graceful shutdown no longer hangs on open SSE connections. Fastify v5's default forceCloseConnections: "idle" only closes idle keep-alive sockets; a connected EventSource kept app.close() pending forever, so SIGTERM never reached process.exit. buildApp() now passes forceCloseConnections: true. Regression test does a real listen + fetch on /api/stream, waits for the connected frame, and asserts app.close() resolves within 2s (fails without the fix).
market_alerts and signal_outcomes no longer grow without bound. The hourly prune (pruneSnapshots → renamed pruneOldRows) now also deletes both tables' rows older than retentionDays (same window as snapshots — summarizeOutcomes full-scans on every /api/outcomes call and the UI contract is recent-200 + summary, so no longer horizon is needed; documented in a comment). listPendingOutcomes(minTs) now takes a required floor — computed in OutcomeTracker.fill as the longest horizon (4h) + 24h grace — so permanently unpriceable symbols stop being re-fetched every minute forever.

Tests: 56 files / 317 passing, typecheck clean.

Two Important findings from the repo-wide review: 1. **Graceful shutdown no longer hangs on open SSE connections.** Fastify v5's default `forceCloseConnections: "idle"` only closes idle keep-alive sockets; a connected EventSource kept `app.close()` pending forever, so SIGTERM never reached `process.exit`. `buildApp()` now passes `forceCloseConnections: true`. Regression test does a real `listen` + fetch on `/api/stream`, waits for the connected frame, and asserts `app.close()` resolves within 2s (fails without the fix). 2. **`market_alerts` and `signal_outcomes` no longer grow without bound.** The hourly prune (`pruneSnapshots` → renamed `pruneOldRows`) now also deletes both tables' rows older than `retentionDays` (same window as snapshots — `summarizeOutcomes` full-scans on every `/api/outcomes` call and the UI contract is recent-200 + summary, so no longer horizon is needed; documented in a comment). `listPendingOutcomes(minTs)` now takes a required floor — computed in `OutcomeTracker.fill` as the longest horizon (4h) + 24h grace — so permanently unpriceable symbols stop being re-fetched every minute forever. Tests: 56 files / 317 passing, typecheck clean.

pregno added 2 commits

2026-06-13 01:04:27 +02:00

fix(server): force-close SSE connections so graceful shutdown completes 05eb63e0f8

Fastify v5's default forceCloseConnections "idle" only closes idle
keep-alive sockets; hijacked SSE replies are never idle, so app.close()
hung forever while any EventSource client was connected and SIGTERM
never finished. Pass forceCloseConnections: true so close() destroys
active sockets too.

fix(server): prune market_alerts/signal_outcomes and bound pending-outcome scans b57b3d7e80

market_alerts and signal_outcomes grew without bound: only snapshots
were pruned, and summarizeOutcomes full-scans signal_outcomes on every
/api/outcomes call. pruneSnapshots becomes pruneOldRows and deletes
old rows from all three tables using the same retentionDays (outcomes
share the snapshot window — the summary scan stays bounded without
promising more history than the rest of the app keeps).

listPendingOutcomes now takes a minTs floor, derived in the tracker
from the longest horizon (4h) plus 24h grace, so permanently
unpriceable symbols stop being re-fetched on every minutely fill pass
forever.

pregno force-pushed fix/server-lifecycle-retention from b57b3d7e80 to 3b9dbb7dca

2026-06-13 01:27:14 +02:00

Compare

pregno merged commit 782c9aebed into main

2026-06-13 01:27:44 +02:00

pregno deleted branch fix/server-lifecycle-retention

2026-06-13 01:27:44 +02:00

pregno referenced this pull request from a commit

2026-06-13 01:27:46 +02:00

fix(server): graceful shutdown with open SSE clients + bounded table growth (#5)