chore(web): surface settings errors, fix catalyst override select, drop dead client code #8

Merged

pregno merged 3 commits from chore/web-polish-deadcode into main

2026-06-13 01:29:54 +02:00

pregno commented

2026-06-13 01:04:50 +02:00

Owner

Three small items from the repo-wide review, one commit each:

Settings save failures now render (same text-destructive pattern as Trading) — previously a rejected save (e.g. zod 400 from a partial numeric input) looked identical to success.
Catalyst override select fixed: selecting "None" now sends catalystTag: null (confirmed the PATCH schema clears on null) instead of persisting the literal string "none" that Scanner rendered as a tag; and a current tag outside CATALYST_CATEGORIES (server accepts any ≤64-char string, e.g. an LLM-produced "spot-bid") is rendered as an extra option so the select reflects reality instead of silently showing the wrong value.
Dead code from the Overview-page removal deleted after repo-wide re-verification: fetchScanner, fetchOutcomes, ackAlert, ackMarketAlert in api/client.ts (plus their orphaned imports and the fetchScanner-only test). Everything still referenced (dismiss/bulk-dismiss, fetchAlerts, fetchMarketAlerts, settings/positions functions) was kept. The server's unused annotations table was intentionally NOT touched — dropping it needs a migration and drizzle-kit generate is currently broken by missing meta snapshots (separate issue).

Tests: 56 files / 313 passing, typecheck clean.

Three small items from the repo-wide review, one commit each: 1. **Settings save failures now render** (same `text-destructive` pattern as Trading) — previously a rejected save (e.g. zod 400 from a partial numeric input) looked identical to success. 2. **Catalyst override select fixed:** selecting "None" now sends `catalystTag: null` (confirmed the PATCH schema clears on null) instead of persisting the literal string "none" that Scanner rendered as a tag; and a current tag outside `CATALYST_CATEGORIES` (server accepts any ≤64-char string, e.g. an LLM-produced "spot-bid") is rendered as an extra option so the select reflects reality instead of silently showing the wrong value. 3. **Dead code from the Overview-page removal deleted** after repo-wide re-verification: `fetchScanner`, `fetchOutcomes`, `ackAlert`, `ackMarketAlert` in `api/client.ts` (plus their orphaned imports and the `fetchScanner`-only test). Everything still referenced (dismiss/bulk-dismiss, `fetchAlerts`, `fetchMarketAlerts`, settings/positions functions) was kept. The server's unused `annotations` table was intentionally NOT touched — dropping it needs a migration and `drizzle-kit generate` is currently broken by missing meta snapshots (separate issue). Tests: 56 files / 313 passing, typecheck clean.

pregno added 3 commits

2026-06-13 01:04:50 +02:00